PycaHash rules were implemented but never wired into PythonDetectionRules#456
Closed
Arijit429 wants to merge 2 commits into
Closed
PycaHash rules were implemented but never wired into PythonDetectionRules#456Arijit429 wants to merge 2 commits into
Arijit429 wants to merge 2 commits into
Conversation
…prevent false positives Signed-off-by: Arijit429 <arijitdeb1203@gmail.com>
Signed-off-by: Arijit429 <arijitdeb1203@gmail.com>
Contributor
|
This PR breaks the tests. See https://github.com/cbomkit/sonar-cryptography/actions/runs/26639691947/job/78533213376?pr=456. You can build locally via
|
Author
Reverting this — PycaHash is intentionally used only as a depending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PycaHash.java covers 17 hash algorithms (SHA1, SHA2, SHA3, SHAKE, MD5,
BLAKE2b/s, SM3, Prehashed) but was never added to PythonDetectionRules.java.
Hash detection was completely inactive for Python as a result.
Added the import and wired PycaHash.rules() into the Stream.of() in
PythonDetectionRules.java alongside the other rule sets.