Repository navigation
Fix/clean pred model - #231
Merged
Merged
Conversation
…X1, etc. renames generic feature references into the actual feature names used by a dataset, while trying not to accidentally modify models that already use the correct names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #229. Nice catch by @Qazi-pk!
I used their examples to create test cases. These tests run for every algorithm because some methods use placeholder feature names in different formats (e.g.,
x1,x_1,x0,X0,x[1], etc), and clean_pred_model uses method-specific conditional logic.This change renames generic feature references to the actual feature names used by the dataset, while avoiding unintended modifications to models that already use the correct names.