Logger class #3

Activity

1. lacava commented on Aug 30, 2022

   

   lacava

   on Aug 30, 2022

   Last edited by lacava

   MemberAuthor

   More actions

   This one looks like a winner: https://github.com/gabime/spdlog

   • has a conda package as well: spdlog
2. lacava

   self-assigned this

   on Dec 20, 2022
3. gAldeia commented on Sep 23, 2026

   

   gAldeia

   on Sep 23, 2026

   Collaborator

   More actions

   In the past, I borrowed several implementations from FEAT (verbosity, calc_stats, logging, and warnings), which were mainly used for debugging and running experiments with Brush.

   I wanted to address this issue without adding another third-party library. I ended up creating PR #72, which includes some code refactoring and fixes to the features originally borrowed from FEAT.

   There is also a very cool notebook illustrating what can be explored from the logs that Brush already generates: https://github.com/cavalab/brush/blob/7888f8cb41cc4508ece0fc3f8e27991472352389/docs/guide/logging.ipynb. I honestly think these features fulfill our logging needs.

   I kept the old Logger class available for future use in case we ever decide to log runtime information.

   My suggestion is to close this issue and merge the PR. I'm open to suggestions and happy to make any changes if needed. Also, if we are not closing this issue, I do think the improvements are worthy to be merged.