🐛 Ensure the PubSubFixture waits for all published messages - #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the PR
The
PubSubFixturewaits for all the messages published during a test to be received by its subscriptions before clearing them, or before checking that no message was published. This wait was ineffective: several expected messages could be satisfied by a single received one, such that the fixture stopped waiting as soon as the first message arrived. Messages still in flight could then leak into the next test, or be missed byexpectNoMessage.The wait now requires as many received messages as there are published ones. Publishes that failed are excluded from that count, as the corresponding messages will never be received.
📋 Check list