fix(repository): make filters match their indexes

[vfusco]

The query builder emitted SUBSTR(col, $1, $2) with bind parameters
while the schema defines its expression indexes over
substring(col FROM n FOR m) with literal offsets. PostgreSQL matches
expression indexes structurally (by function identity and argument
tree), so every filter routed through SubstrBytea bypassed the four
indexes written for it and fell back to sequential scans. Emit the
substring form with inline literal offsets instead.

Also require the Voucher/DelegateCallVoucher selector when filtering
by voucher address: bytes 17..36 of other output types are arbitrary
payload, so the old filter could match notices, and the selector IN
list (inline literals) is what lets the planner prove the partial
predicate of output_raw_data_address_idx, even under generic plans.

Verified with EXPLAIN on PostgreSQL 17.10: both filters now produce
index scans; the voucher-address query uses the partial index with a
bound address parameter under force_generic_plan.

[Copilot]

Pull request overview

This PR updates the PostgreSQL repository query builder so output filters structurally match the schema’s expression/partial indexes (enabling index scans instead of sequential scans), and tightens the voucher-address filter to only apply to voucher-typed outputs.

Changes:

• Change SubstrBytea to emit substring(col FROM n FOR m) with inline literal offsets to match expression indexes.
• Add ByteaLiteral and use an inline-literal selector IN list when filtering by voucher address, so the planner can prove the partial-index predicate.
• Extend repository tests to ensure non-voucher outputs with “lookalike” payloads don’t match the voucher-address filter.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
internal/repository/repotest/output_test_cases.go	Strengthens the voucher-address filter test by adding a non-voucher lookalike payload case.
internal/repository/postgres/util.go	Makes substring rendering index-compatible and introduces inline bytea literal rendering for partial-index predicate implication.
internal/repository/postgres/output.go	Restricts voucher-address filtering to voucher selectors and uses inline selector literals to enable partial index usage.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.