Show entry/exit timestamps on GridLadderCard and add unit tests - #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
GridLadderStatusvalue andformatTimestamputil and update theGridLadderCardto display anEntry timerow usingladder.created_atformatted viaformatTimestamp.Exit timerow that renders whenladder.status === GridLadderStatus.CLOSEDandladder.closed_atis present, usingformatTimestampfor display.GridLadderStatusin as a runtime value instead of a type-only import.GridLadderCard.test.tsxthat verify the entry timestamp is shown and that the exit timestamp appears before theTotal realizedrow when the ladder is closed.Testing
vitestfor the component tests inGridLadderCard.test.tsxwhich include two cases and both tests passed.Entry timelabel and formatted entry time, and for the formattedExit timeand its ordering relative toTotal realized, and they succeeded.Codex Task