searchable codemod: add republish tool#5368
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 510138ffb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
Adds follow-up tooling for the deployed-realm “searchable” migration: a republish driver to refresh published snapshots, and enhanced tolerance/reporting when realm pull returns non-zero due to stray forbidden objects.
Changes:
- Added
republish.mjsto republish each (source → published) pair and verifysearchableannotations landed by reading back a known module. - Updated
apply-deployed.tsto continue crawling whenrealm pullexits non-zero but the pulled realm still containsrealm.json, recording apullWarningin the output report.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/realm-server/scripts/codemod/searchable/republish.mjs | New script to republish published realm copies from their sources and assert searchable annotations appear post-indexing. |
| packages/realm-server/scripts/codemod/searchable/apply-deployed.ts | Makes deployed crawl “pull-tolerant” by proceeding on partial pulls (when realm.json exists) and surfacing a pullWarning in the report/output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
habdelra
force-pushed
the
searchable-codemod-deployed-tooling
branch
from
510138f to
ec2b385
Compare
republish.mjs republishes each published realm copy from its source
realm so the published snapshot picks up the source's searchable
annotations, then reads a known module back from the published realm to
assert the annotation landed. The env argument is checked against a
staging|prod allow-list before it is interpolated into the bash command
that sources the seed file. The run exits nonzero on a real failure or a
missing-searchable assertion, while a realm the server refuses to publish
("not publishable") is recorded as an expected skip and does not fail it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0182qehwDYbwBmyYcAhMoij1
habdelra
force-pushed
the
searchable-codemod-deployed-tooling
branch
from
ec2b385 to
0c41b87
Compare
habdelra
changed the title
lukemelia
approved these changes
Jun 30, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
republish.mjs, the publish-side tool for thesearchablemigration: it republishes each published realm copy from its (now-annotated) source realm so the published snapshot picks up the source'ssearchableannotations, then reads a known module back from the published realm to assert the annotation landed.realm publishwaits for the published realm to finish indexing before that read.Args:
<pairs.json> <staging|prod> <out.jsonl> [--limit N].envargument is allow-listed tostaging|prodbefore it is interpolated into that shell command.searchableassertion, while a realm the server refuses to publish ("not publishable") is recorded as an expected skip and does not fail the run.