Remove some pill-related virtual networks in card API#5366
Open
backspace wants to merge 2 commits into
Open
Conversation
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 33m 6s ⏱️ Results for commit 453e5b9. Realm Server Test Results 1 files ±0 1 suites ±0 10m 33s ⏱️ -4s Results for commit 453e5b9. ± Comparison against earlier commit a78523a. |
backspace
changed the title
…ualNetwork)
The BFM `:card[...]` / `:file[...]` reference extractors resolved each
reference to a real URL through a VirtualNetwork to feed the
linkedCards/linkedFiles `in:{id}` / `in:{url}` queries. Identifiers are
canonical RRI, so resolve in RRI space instead (resolveRRIReference) and drop
the VirtualNetwork parameter — the search index matches a canonical-RRI value
for these reference queries. References that can't be resolved to an absolute
identifier are dropped, as before.
Touches bfm-card-references (extractBfmReferences / extractCardReferenceUrls /
extractFileReferenceUrls) and the rich-markdown / markdown-file-def /
rendered-markdown query call sites.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…alNetwork) rendered-markdown keys its loadedCards/loadedFiles maps by the RRI-space ids that extractCardReferenceUrls/extractFileReferenceUrls produce, but the slot-matching resolveUrl still resolved each DOM ref through the VirtualNetwork (resolveRRI). Resolve slots with the same resolveRRIReference helper so a slot's key matches its loaded instance's map key VN-free; the network service is then unused and dropped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
pills-query-fields-no-vn-cs-11730
branch
from
a78523a to
453e5b9
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 453e5b9489
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #5349 and #5356.