Skip to content

fix texture mip flicker on instanced meshes, by reporting screen size per pass and never reporting 0#24

Merged
Ikreb1 merged 1 commit into
mainfrom
investigation/plat-11597-antenna-lod-flicker
Jul 10, 2026
Merged

fix texture mip flicker on instanced meshes, by reporting screen size per pass and never reporting 0#24
Ikreb1 merged 1 commit into
mainfrom
investigation/plat-11597-antenna-lod-flicker

Conversation

@Ikreb1

@Ikreb1 Ikreb1 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Fix texture-mip flicker on instanced meshes (PLAT-11597): report screen sizes per pass and never report 0. passes that culled a mesh were overwriting the frame's screen size, flapping the streamed mip at reflection-probe cadence.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes texture-mip flicker on instanced meshes by ensuring texture LOD “usage” (screen size) is reported per render pass and that a screen size of 0 is never reported to materials (preventing spurious full-resolution mip requests when a pass culls a mesh).

Changes:

  • Call EveInstancedMeshManager::ReportUsedScreenSizes() immediately after instanced batch gathering in the main scene gather and in the reflection pass.
  • Update ReportUsedScreenSizes() to skip reporting when maxScreenSize is 0, and avoid unnecessary mesh LOD lookups in that case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
trinity/Eve/EveSpaceScene.cpp Reports instanced-mesh screen sizes right after batch generation for the primary gather and reflection pass, preventing later passes from affecting per-frame texture LOD requests.
trinity/Eve/EveInstancedMeshManager.cpp Prevents reporting 0 screen sizes to materials and avoids extra work when nothing meaningful should be reported.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ikreb1 Ikreb1 merged commit 0c6e711 into main Jul 10, 2026
22 checks passed
@Ikreb1 Ikreb1 deleted the investigation/plat-11597-antenna-lod-flicker branch July 10, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants