Don't build cstool arch specific details printing, if not requested.#2888
Open
Rot127 wants to merge 3 commits into
Open
Don't build cstool arch specific details printing, if not requested.#2888Rot127 wants to merge 3 commits into
Rot127 wants to merge 3 commits into
Conversation
Rot127
force-pushed
the
cstool-build
branch
10 times, most recently
from
2cb39f9 to
b578610
Compare
wargio
reviewed
Jul 7, 2026
wargio
left a comment
wargio
left a comment
Collaborator
There was a problem hiding this comment.
shouldn't you change also the output of cstool -h ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This limits the output of
cstoolto the archs enabled during the build.This will on the one hand not compile unnecessary detail printing code. On the other also limit the help output to the architectures which are enabled.
It also fixes a build issue reported in #2887
TODO:
Test plan
...
Closing issues
closes #2887