feat: add Electron app version constraint flags for live update bundles#185
Open
robingenz wants to merge 1 commit into
Open
feat: add Electron app version constraint flags for live update bundles#185robingenz wants to merge 1 commit into
robingenz wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Electron app version constraint support to the Live Updates CLI flows by introducing three new optional flags and wiring them through to the bundle create DTO fields expected by the backend.
Changes:
- Add
--electron-min,--electron-max, and--electron-eqoptions toapps:liveupdates:uploadandapps:liveupdates:register. - Extend the bundle DTO types to include
minElectronAppVersionCode/maxElectronAppVersionCode/eqElectronAppVersionCode. - Add the same Electron flags to the deprecated
apps:bundles:createandapps:bundles:updatecommands for consistency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/app-bundle.ts | Adds Electron version constraint fields to the Create/Update bundle DTO interfaces. |
| src/commands/apps/liveupdates/upload.ts | Introduces Electron constraint flags and forwards them in the bundle creation request payload. |
| src/commands/apps/liveupdates/register.ts | Introduces Electron constraint flags and forwards them in the bundle registration request payload. |
| src/commands/apps/bundles/create.ts | Adds Electron constraint flags to the deprecated create command’s options for parity. |
| src/commands/apps/bundles/update.ts | Adds Electron constraint flags to the deprecated update command’s options for parity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+90
| electronMax: z | ||
| .string() | ||
| .optional() | ||
| .describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'), | ||
| electronMin: z |
Comment on lines
+63
to
+67
| electronMax: z | ||
| .string() | ||
| .optional() | ||
| .describe('The maximum Electron app version (`app.getVersion()`) that the bundle supports.'), | ||
| electronMin: z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds three optional flags to
apps:liveupdates:uploadandapps:liveupdates:register(and, for consistency, to the deprecatedapps:bundles:create/updatecommands), mirroring the existing Android/iOS version-constraint flags:--electron-eq→eqElectronAppVersionCode--electron-min→minElectronAppVersionCode--electron-max→maxElectronAppVersionCodeThe values are Electron app versions as returned by
app.getVersion()(semver-style strings, validated server-side like the iOS fields). Backend support lands in capawesome-team/cloud-api-worker#695.Tests
npm run build,npm run test(201 tests),npm run lint— all green.Related PRs
https://github.com/capawesome-team/cloud-api-worker/pull/695 — backend: Electron platform support incl. the new constraint fields
https://github.com/capawesome-team/electron-live-update/pull/1 — engine: manifest delta updates, channel discovery
feat: add watchdog opt-out and async plugin initialize hook capacitor-electron#6 — platform: watchdog opt-out + initialize() hook
https://github.com/feat(live-update): add Electron platform support capacitor-plugins#921 — plugin: Electron platform implementation (the Capacitor adapter)
🤖 Generated with Claude Code