Skip to content

feat: add apps:builds:unshare command#184

Merged
robingenz merged 1 commit into
mainfrom
feat/unshare-command
Jul 12, 2026
Merged

feat: add apps:builds:unshare command#184
robingenz merged 1 commit into
mainfrom
feat/unshare-command

Conversation

@robingenz

Copy link
Copy Markdown
Member

What

Adds apps:builds:unshare to revoke the public share link of a build from the CLI — the symmetric counterpart to apps:builds:share, following the existing apps:link/apps:unlink naming pattern.

  • Resolves the build via --app-id and --build-id or --build-number (with interactive selection, like apps:builds:share).
  • Looks up the active share and calls the existing revoke endpoint; errors with a clear message when the build is not shared.
  • Asks for confirmation before revoking (skippable with --yes), matching the delete-command convention.

Copilot AI review requested due to automatic review settings July 12, 2026 13:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CLI command, apps:builds:unshare, to revoke a public share link for an app build, complementing the existing apps:builds:share flow and extending the app-build service layer to support listing and deleting shares.

Changes:

  • Introduces apps:builds:unshare command with non-interactive behavior matching existing command patterns.
  • Extends AppBuildsService with findAllShares and deleteShare methods and corresponding DTOs.
  • Adds Vitest coverage for the new command’s basic success and error paths, and wires the command into the CLI entrypoint.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/types/app-build.ts Adds DTOs for listing and deleting app build shares.
src/services/app-builds.ts Implements share listing and share deletion endpoints in the service layer.
src/index.ts Registers the new apps:builds:unshare command.
src/commands/apps/builds/unshare.ts Implements the unshare CLI command logic (resolve build, find share, revoke).
src/commands/apps/builds/unshare.test.ts Adds initial tests for revoking a share and common error conditions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/apps/builds/unshare.ts
Comment thread src/commands/apps/builds/unshare.test.ts
@robingenz robingenz self-assigned this Jul 12, 2026
@robingenz robingenz added the feature Feature label Jul 12, 2026
@robingenz robingenz merged commit 55ecd8e into main Jul 12, 2026
4 checks passed
@robingenz robingenz deleted the feat/unshare-command branch July 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants