feat: add apps:builds:unshare command#184
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CLI command, apps:builds:unshare, to revoke a public share link for an app build, complementing the existing apps:builds:share flow and extending the app-build service layer to support listing and deleting shares.
Changes:
- Introduces
apps:builds:unsharecommand with non-interactive behavior matching existing command patterns. - Extends
AppBuildsServicewithfindAllSharesanddeleteSharemethods and corresponding DTOs. - Adds Vitest coverage for the new command’s basic success and error paths, and wires the command into the CLI entrypoint.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/app-build.ts | Adds DTOs for listing and deleting app build shares. |
| src/services/app-builds.ts | Implements share listing and share deletion endpoints in the service layer. |
| src/index.ts | Registers the new apps:builds:unshare command. |
| src/commands/apps/builds/unshare.ts | Implements the unshare CLI command logic (resolve build, find share, revoke). |
| src/commands/apps/builds/unshare.test.ts | Adds initial tests for revoking a share and common error conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
apps:builds:unshareto revoke the public share link of a build from the CLI — the symmetric counterpart toapps:builds:share, following the existingapps:link/apps:unlinknaming pattern.--app-idand--build-idor--build-number(with interactive selection, likeapps:builds:share).--yes), matching the delete-command convention.