fix: run deployment before --json output in apps:builds:create#182
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes apps:builds:create output ordering so that when --json is used together with deployment delegation (--channel / --destination), the final JSON document remains the last content written to stdout, preventing downstream JSON parsers from receiving trailing non-JSON output.
Changes:
- Moved the deployment delegation (
apps:deployments:create) to run before the--jsonoutput block. - Scoped the deployment delegation to the “wait for completion” branch (where it can safely run after the build finishes and after the optional share step).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
apps:builds:create, the deployment delegation (triggered by--channelor--destination) ran after the--jsonoutput block, so the delegatedapps:deployments:createoutput landed on stdout after the JSON document. Consumers that parse the JSON tail of the command output received invalid input when--jsonwas combined with--channelor--destination.The deployment delegation now runs inside the wait-for-completion branch, after the share step and before the JSON output, so the JSON document is always the last thing written to stdout. Since
--detachedis already rejected in combination with--channelor--destination, the detached branch does not need the deployment block.Close #180