Skip to content

Fix subscription test failure - #602

Merged
akgarg06 merged 5 commits into
developfrom
RBSDMS-subscription-test-cases-fix-feature
Oct 1, 2026
Merged

akgarg06 merged 5 commits into
developfrom
RBSDMS-subscription-test-cases-fix-feature

Conversation

@akgarg06

@akgarg06 akgarg06 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

  • Fixed IntegrationTest_Subscription failing at @BeforeAll with AssertionFailedError: Initial subscription should succeed ==> expected: <0> but was: <1>
  • Root cause: cf-subscribe.sh and cf-unsubscribe.sh crashed with a bash unbound variable error before the subscription could be attempted

Fix

Added :- (default-empty) modifier to the indirect expansion:

# Before
consumerSubaccountIdMT="${!SUBACCOUNT_VAR}"

# After
consumerSubaccountIdMT="${!SUBACCOUNT_VAR:-}"

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Multi-tenancy test cases : https://github.com/cap-java/sdm/actions/runs/36823932306

@akgarg06
akgarg06 deployed to pr-analysis October 1, 2026 05:53 — with GitHub Actions Active
@akgarg06
akgarg06 deployed to pr-analysis October 1, 2026 05:53 — with GitHub Actions Active

@PujaDeshmukh17 PujaDeshmukh17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akgarg06
akgarg06 merged commit 68fd46b into develop Oct 1, 2026
64 checks passed
@akgarg06
akgarg06 deleted the RBSDMS-subscription-test-cases-fix-feature branch October 1, 2026 08:50

This branch was successfully deployed

2 active deployments
dev — dbe8bd2d Deployed Oct 1, 2026 by akgarg06 via test-summary #245
pr-analysis — dbe8bd2d Deployed Oct 1, 2026 by akgarg06 via sonar-scan #2277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants