Skip to content

Merge Snapshot 10.3 branch changes to develop - #600

Merged
akgarg06 merged 12 commits into
developfrom
RBSDMS-v1.10.3-SNAPSHOT-feature
Sep 28, 2026
Merged

akgarg06 merged 12 commits into
developfrom
RBSDMS-v1.10.3-SNAPSHOT-feature

Conversation

@akgarg06

@akgarg06 akgarg06 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

Summary

Fixed an upload issue where attachment path mappings were incorrectly resolved for entities with deeply nested compositions (e.g., Entity → Sections → attachments)
Introduced recursive path traversal (findPathToEntity) to correctly build the actual upload path when an attachment belongs to an intermediate entity rather than the direct target entity
Updated buildActualPath to accept targetEntity and distinguish between direct and nested attachment ownership before constructing the path
Updated buildEntityPath to use the attachmentPath as-is for nested attachments, ensuring uniqueness at any composition depth

Root Cause

The previous logic always built the actual path using parentEntity + compositionPropertyName + attachmentPart, which was incorrect when the attachment was owned by an intermediate composition (not the direct target entity). This caused path mismatches during upload.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Single Tenant : https://github.com/cap-java/sdm/actions/runs/36387314294
Multi Tenant : https://github.com/cap-java/sdm/actions/runs/36387286716

@akgarg06
akgarg06 deployed to pr-analysis September 28, 2026 06:22 — with GitHub Actions Active
@akgarg06
akgarg06 deployed to pr-analysis September 28, 2026 06:22 — with GitHub Actions Active
@akgarg06
akgarg06 marked this pull request as ready for review September 28, 2026 08:08
@akgarg06
akgarg06 merged commit da618ab into develop Sep 28, 2026
9 checks passed
@akgarg06
akgarg06 deleted the RBSDMS-v1.10.3-SNAPSHOT-feature branch September 28, 2026 08:18

This branch was successfully deployed

1 active deployment
pr-analysis — c52b8414 Deployed Sep 28, 2026 by akgarg06 via build #2084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants