fix: Use EDMX providers for loading OData API definitions - #32
Merged
Merged
Conversation
mlakov
force-pushed
the
fix/use-edmx-providers-for-loading-api-definitions
branch
from
September 15, 2026 06:09
793dcee to
ab9d2ae
Compare
mlakov
marked this pull request as ready for review
September 15, 2026 06:09
There was a problem hiding this comment.
No additional review findings from my side. The change is small and focused; the main behavior is covered by new tests for both static and dynamic providers.
PR Bot Information
Version: 1.31.30
- Event Trigger:
pull_request.ready_for_review - Correlation ID:
0f0a3460-b0cc-11f1-94f3-e4dff5f280b0 - File Content Strategy: Full file content
- LLM:
gpt-5.5
InaGlushkova
approved these changes
Sep 15, 2026
InaGlushkova
self-requested a review
September 15, 2026 09:05
InaGlushkova
approved these changes
Sep 15, 2026
mlakov
deleted the
fix/use-edmx-providers-for-loading-api-definitions
branch
September 15, 2026 09:10
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ORD EDMX Resource Loading via Runtime Providers
Bug Fix
🐛 Ensures OData API definition resources (
.edmx) are loaded through the registeredEdmxV4Providerinstead of being treated as static resources or fetched from the MTX sidecar. This aligns EDMX generation with the CDS runtime provider for both static and dynamic ORD resource loading.Changes
cds-feature-ord/src/main/java/com/sap/cds/feature/ord/configuration/OrdResourcesProviderConfiguration.java: PassesCdsRuntimeinto the dynamic ORD resources provider so it can access registered runtime providers.cds-feature-ord/src/main/java/com/sap/cds/feature/ord/provider/impl/DynamicOrdResourcesProviderImpl.java: Detects.edmxresource requests and resolves them viaEdmxV4Provider#getEdmx(...); keeps existing MTX sidecar loading for non-EDMX resources.cds-feature-ord/src/main/java/com/sap/cds/feature/ord/provider/impl/StaticOrdResourcesProviderImpl.java: Adds EDMX-specific loading throughEdmxV4Providerwhile preserving existing ORD document and static resource behavior.cds-feature-ord/src/test/java/com/sap/cds/feature/ord/provider/impl/DynamicOrdResourcesProviderImplTest.java: Updates setup for the new runtime dependency and adds coverage for dynamic EDMX resource resolution.cds-feature-ord/src/test/java/com/sap/cds/feature/ord/provider/impl/StaticOrdResourcesProviderImplTest.java: Adds coverage for static EDMX resource resolution and updates runtime construction in existing tests.PR Bot Information
Version:
1.31.304b1dd7e0-b0cc-11f1-96c6-6c8c474c9810issue_comment.edited