Skip to content

fix: Use EDMX providers for loading OData API definitions - #32

Merged
mlakov merged 1 commit into
mainfrom
fix/use-edmx-providers-for-loading-api-definitions
Sep 15, 2026
Merged

mlakov merged 1 commit into
mainfrom
fix/use-edmx-providers-for-loading-api-definitions

Conversation

@mlakov

@mlakov mlakov commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Fix ORD EDMX Resource Loading via Runtime Providers

Bug Fix

🐛 Ensures OData API definition resources (.edmx) are loaded through the registered EdmxV4Provider instead of being treated as static resources or fetched from the MTX sidecar. This aligns EDMX generation with the CDS runtime provider for both static and dynamic ORD resource loading.

Changes

  • cds-feature-ord/src/main/java/com/sap/cds/feature/ord/configuration/OrdResourcesProviderConfiguration.java: Passes CdsRuntime into the dynamic ORD resources provider so it can access registered runtime providers.
  • cds-feature-ord/src/main/java/com/sap/cds/feature/ord/provider/impl/DynamicOrdResourcesProviderImpl.java: Detects .edmx resource requests and resolves them via EdmxV4Provider#getEdmx(...); keeps existing MTX sidecar loading for non-EDMX resources.
  • cds-feature-ord/src/main/java/com/sap/cds/feature/ord/provider/impl/StaticOrdResourcesProviderImpl.java: Adds EDMX-specific loading through EdmxV4Provider while preserving existing ORD document and static resource behavior.
  • cds-feature-ord/src/test/java/com/sap/cds/feature/ord/provider/impl/DynamicOrdResourcesProviderImplTest.java: Updates setup for the new runtime dependency and adds coverage for dynamic EDMX resource resolution.
  • cds-feature-ord/src/test/java/com/sap/cds/feature/ord/provider/impl/StaticOrdResourcesProviderImplTest.java: Adds coverage for static EDMX resource resolution and updates runtime construction in existing tests.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.31.30

  • Correlation ID: 4b1dd7e0-b0cc-11f1-96c6-6c8c474c9810
  • Event Trigger: issue_comment.edited

@mlakov
mlakov requested a review from StefanHenke September 11, 2026 14:55
@mlakov
mlakov force-pushed the fix/use-edmx-providers-for-loading-api-definitions branch from 793dcee to ab9d2ae Compare September 15, 2026 06:09
@mlakov
mlakov marked this pull request as ready for review September 15, 2026 06:09

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional review findings from my side. The change is small and focused; the main behavior is covered by new tests for both static and dynamic providers.

PR Bot Information

Version: 1.31.30

  • Event Trigger: pull_request.ready_for_review
  • Correlation ID: 0f0a3460-b0cc-11f1-94f3-e4dff5f280b0
  • File Content Strategy: Full file content
  • LLM: gpt-5.5

@mlakov
mlakov requested a review from InaGlushkova September 15, 2026 06:36
@InaGlushkova
InaGlushkova self-requested a review September 15, 2026 09:05
@mlakov
mlakov merged commit 31c8447 into main Sep 15, 2026
7 of 8 checks passed
@mlakov
mlakov deleted the fix/use-edmx-providers-for-loading-api-definitions branch September 15, 2026 09:10
@hyperspace-pr-bot hyperspace-pr-bot Bot mentioned this pull request Sep 15, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants