Conversation
Contributor
There was a problem hiding this comment.
I didn’t find any substantive issues in the documentation changes worth an inline review comment. The updates appear consistent with the referenced implementation details and improve handover context without changing executable behavior.
PR Bot Information
Version: 1.31.48
- LLM:
gpt-5.5 - File Content Strategy: Full file content
- Agent Instructions:
- Correlation ID:
4e086f40-b65f-11f1-910b-91a0fdbb111b - Event Trigger:
pull_request.opened
lisajulia
force-pushed
the
update-claude-md
branch
from
September 22, 2026 08:32
cc413ad to
6a83a74
Compare
busehalis-sap
approved these changes
Sep 22, 2026
Schmarvinius
approved these changes
Sep 22, 2026
Schmarvinius
left a comment
Contributor
There was a problem hiding this comment.
lgtm but i find it interesting to document the decision we haven't done. The rationale is sound imo but still
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document Attachment Architecture and Design Decisions
Documentation
📚 Updated
CLAUDE.mdwith additional architecture notes and handover context for the attachments feature, improving guidance for future maintainers and contributors.Changes
CLAUDE.md: Added documentation for the two supported attachment models: composition-based attachments and inline attachment fields, including how inline attachments are detected and handled viaFieldAccessor.CLAUDE.md: Clarified theDefaultAttachmentsServiceHandlerexecution order and how storage plugins intercept attachment service events before the default DB handler.CLAUDE.md: Documented storage plugin behavior for OSS/FS handlers, includingcontext.setCompleted()andsetIsInternalStored(false)handling.CLAUDE.md: Added a new “Non-obvious Design Decisions” section covering:CreationChangeSetListener.$valuedownload detection viaareKeysEmpty.CLAUDE.md: Expanded key pattern descriptions for outbox usage and thread-local context bridging.PR Bot Information
Version:
1.31.48gpt-5.54e086f40-b65f-11f1-910b-91a0fdbb111bpull_request.opened