Repository navigation
upgrade nixpkgs to fix gcloud crash on MacOS 27 - #7600
Merged
Merged
Conversation
Deal with NixOS/nixpkgs#541367 on MacOS 27: $ gcloud --version Assertion failed: (trampoline_handle), function ffi_trampoline_table_alloc_block_invoke, file closures.c, line 258. Abort trap: 6 - update to NixOS/nixpkgs@b6c8664 - the latest nixpkgs-unstable ref there at time of writing - remove #6102 workaround for helm-unittest Assisted-by: Copilot:gpt-6-astra Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Avoid these errors in direnv load, introduced in NixOS/nixpkgs#518407: trace: evaluation warning: stdenv.isDarwin is deprecated, use stdenv.hostPlatform.isDarwin instead trace: evaluation warning: stdenv.isAarch64 is deprecated, use stdenv.hostPlatform.isAarch64 instead Assisted-by: Copilot:gpt-6-astra Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Show the package version changes in the nix dev shell between the merge-base with origin/main and the working tree, for the current system, e.g. to review a nixpkgs bump. Assisted-by: Claude:claude-5.5-opus Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
The firefox-157.0 wrapper in NixOS/nixpkgs@b6c8664 does not build on aarch64-linux, and is not on cache.nixos.org: error: output '/nix/store/9n53j9xnff4l259qm822a31qbh9qdzhb-firefox-157.0' is not allowed to refer to the following paths: /nix/store/99zij8qfs8wzbb2njrj18ys8hpnrcj3p-gcc-wrapper-16.2.0 - update to NixOS/nixpkgs@f45c6f0 - the previous nixpkgs-unstable ref, with firefox 156.0.1 cached for aarch64-linux and x86_64-linux - still includes the darwin.libffi fix NixOS/nixpkgs@3f92b69 Assisted-by: Claude:claude-5.5-opus Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
stephencompall-DA
force-pushed
the
s11/macos-27-gcloud-nixpkgs
branch
from
October 2, 2026 17:00
98bcc79 to
edee634
Compare
npm 11.19.0, bundled with nodejs 24.20.0 from the nixpkgs bump, prints a
warning for every dependency install script not listed in the new
package.json `allowScripts` field, which fails the sbt output check:
npm warn install-scripts 2 packages have install scripts not yet covered by allowScripts:
npm warn install-scripts msw@2.7.3 (postinstall: node -e "try{require('./config/scripts/postinstall')}catch(e){}")
npm warn install-scripts openapi-ts-client@3.6.0-SNAPSHOT (prepare: npm run build)
These scripts still run (only `false` entries skip them), so approve the
ones we already rely on, by name and not version, with
`npm install-scripts approve --no-allow-scripts-pin --all`. That command
refuses to run in a workspace member, so the token-standard entry for
the canton-json-api-v2 client that `npm ci` in token-standard/cli builds
is written by hand in the same form.
Assisted-by: Claude:claude-5.5-opus
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Firefox 156 from the nixpkgs bump breaks two things in the frontend tests:
- BiDi browsingContext.domContentLoaded events now carry a userContext
field, which NavigationInfo.fromJson did not expect:
Caused by: scala.MatchError: userContext (of class java.lang.String)
Skip fields we don't read instead.
- Navigating to a URL without a scheme is rejected; Firefox 152 treated
it as http:
org.openqa.selenium.UnsupportedCommandException: Navigation to "scan.localhost:4000" is not allowed in this context
Use http:// URLs in the two docker-compose tests that did this.
Assisted-by: Claude:claude-5.5-opus
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
stephencompall-DA
requested review from
krzysztofczyz-da,
martinflorian-da and
ray-roestenburg-da
October 6, 2026 13:46
stephencompall-DA
marked this pull request as ready for review
October 6, 2026 13:46
martinflorian-da
approved these changes
Oct 6, 2026
martinflorian-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks! In case you find no one at DA with an old Mac OS version you could also try asking on #splice-contributions-external
Contributor
There was a problem hiding this comment.
Consider documenting this on some (potentially internal) README or at least making it known via Slack that this exists now. Surely helpful for future debugging.
…s-27-gcloud-nixpkgs
- suggested by @martinflorian-da; thanks Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
ray-roestenburg-da
approved these changes
Oct 6, 2026
ray-roestenburg-da
left a comment
Contributor
There was a problem hiding this comment.
Tried on macOS 26, everything works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deal with NixOS/nixpkgs#541367 on MacOS 27:
stdenv.hostPlatform.is*instead ofstdenv.is*, avoiding warnings added in stdenv: deprecate is* aliases in favor of hostPlatform.is* NixOS/nixpkgs#518407userContextfield, scheme requiredallowScriptsfieldFixes #7615.
Extra tests
direnv reloadgcloud --versionworkspython3 -c 'import ctypes'worksmake cluster/helm/testpasses; Bump nix #6102's workaround had macOS-specific variants, so the upstream fix needs checking on darwinsbt --clientworksdirenv reloadgcloud --versionworkspython3 -c 'import ctypes'worksmake cluster/helm/testpasses; Bump nix #6102's workaround had macOS-specific variants, so the upstream fix needs checking on darwinsbt --clientworksaarch64-linuxMost notable upgrades
Full upgrade list
From
scripts/nixpkgs-version-changes.shPull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines