Skip to content

Add interactive SQL parser dashboard command - #67

Merged
cangelosilima merged 2 commits into
mainfrom
codex/parser-dashboard
Sep 26, 2026
Merged

cangelosilima merged 2 commits into
mainfrom
codex/parser-dashboard

Conversation

@cangelosilima

@cangelosilima cangelosilima commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Adds syncsql parser --file <path.sql> to inspect SQL Server and Oracle scripts in a read-only terminal dashboard without a database connection. Seven views expose the syntax tree, tokens, referenced objects, aliases, columns, parse diagnostics, and source, with keyboard navigation, filtering, and detail scrolling. --engine oracle selects PL/SQL; --plain and redirected terminals print a text report.

The console boundary is isolated so tests exercise navigation, resize, cancellation, and terminal disconnection. Ctrl+C mode is restored even if writing the terminal cleanup sequence fails. Parser tests cover legacy SQL fallback, lexer diagnostics, semantic references, source positions, and invalid/empty input.

Validation:

  • Full Release solution build: no warnings or errors.
  • CLI: 1,107 tests passed, 21 skipped; 100% line, branch, method, and full-method coverage, verified locally and in the GitHub CLI coverage job.
  • Site locally: 534 tests passed, 1 skipped; 100% statement, branch, function, and line coverage. GitHub site coverage also passes.
  • Formatting, lint, type checking, and Git LFS pointer validation passed.
  • Latest push passed the complete pre-push hook without bypassing checks or changing coverage exclusions/thresholds. Local site checks used compatible Node web-storage settings and an explicit Git worktree path.
  • CLI CI, Site CI, benchmark, and all Quality jobs except the still-running C# CodeQL analysis are green at commit 85fbb5f4549a276e6879a06fc478fec7ddbe4b6a.

The coverage failure reported by the quality bot is fixed. The final Quality gate awaits C# CodeQL; see the current run.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Quality results

Quality gate: success
Commit: 85fbb5f4549a276e6879a06fc478fec7ddbe4b6a · View run and reports

Check Result
Dependency vulnerabilities success
CodeQL success
CLI lint and format success
CLI tests and coverage success
CLI performance budgets success
Site lint and format success
Site tests and coverage success
Workflow lint success
Coverage badge data success
Line coverage Measured Minimum
CLI 100% 100%
Site 100% 80%

CLI line, branch, method, and full method coverage must each reach 100%. A missing report is shown as unavailable. See the linked run for test failures, detailed CLI/Site coverage summaries and HTML reports, and scanner results.

@cangelosilima
cangelosilima marked this pull request as ready for review September 26, 2026 17:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T17:35:26.490376Z 85fbb5f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cangelosilima
cangelosilima merged commit 7ecc362 into main Sep 26, 2026
25 checks passed
@cangelosilima
cangelosilima deleted the codex/parser-dashboard branch September 26, 2026 17:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85fbb5f454

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

private static string Fit(string text, int width)
{
string safe = Safe(text);
return safe.Length > width ? safe[..width] : safe.PadRight(width);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Account for terminal display width when fitting rows

When a filename, identifier, or SQL line contains CJK characters, emoji, or combining marks, string.Length does not equal the number of terminal cells occupied. A row containing double-width glyphs can therefore exceed the reserved final column and wrap, corrupting the dashboard layout; truncation may also split a surrogate pair. Fit, truncate, pad, and horizontally pan content using terminal display-cell width rather than UTF-16 code-unit count.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant