Remove dynamic SQL investigation opt-out - #66
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Quality resultsQuality gate: success
CLI line, branch, method, and full method coverage must each reach 100%. A missing report is shown as unavailable. See the linked run for test failures, detailed CLI/Site coverage summaries and HTML reports, and scanner results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog builds now always investigate dynamic SQL for SQL Server and Oracle. Remove
--no-dynamic-sql, the catalog and analyzer opt-out properties, and visitor branches that disabled investigation. Existing scan budgets and handling of unknown SQL expressions remain intact.Update the documentation and regression tests, including rejection of the removed CLI option and preservation of static and dynamic references in mixed statements.
Validation: full CLI solution tests passed (974 passed, 21 skipped); formatting checked for the changed C# files.
The complete pre-push hook passed: Release build, CLI coverage (100% lines/branches/methods), site formatting/lint/typecheck, and site tests (534 passed, 1 skipped; 100% coverage).