[andresbott]

Summary

On macOS the default server password file lives under ~/Library/Application Support, but daemon validation rejected whitespace in the password-file path, so password-protected rsync servers could not be used there. Changing a server's Password file path also left the config pointing at a missing file, and the connection check still passed because rsync reports password-file errors only per module, where they were ignored.

What

• Password-file paths may contain spaces (rsync gets the path as one exec argument); a leading - and line breaks are still rejected.
• CheckConnection validates the password file before contacting the daemon (readable, not a directory, not accessible to other users), and the server form suggests typing the password when the file is missing.
• Changing the Password file path without retyping the password moves the existing file there: it is copied when another server or profile still uses it, left alone when the target already exists, and rolled back if the config save fails.
• Password files are written atomically, so an existing file with looser permissions is replaced by a fresh 0600 file instead of keeping its mode.