chore(ci): skip expensive jobs on non-source changes by cameri · Pull Request #565 · cameri/nostream

cameri · 2026-04-22T10:08:03Z

Summary

Adds a changes job using dorny/paths-filter@v3 to detect whether source-affecting files changed (src/, test/, package.json, tsconfig*.json, biome.json, .knip.json, Dockerfiles, .nvmrc, and the workflow file itself)
Gates lint, build-check, and both test jobs behind needs.changes.outputs.src == 'true' so they skip on docs/config-only PRs
Fixes commit-lint false positives on squash-merges by restricting it to pull_request and workflow_dispatch only
Guards post-tests Coveralls parallel-finished signal to only fire when at least one test job ran (prevents spurious 0% coverage reports)
Bumps actions/checkout and actions/setup-node from @v3 → @v4

Why job-level filter instead of trigger-level `paths:`

GitHub only satisfies required status checks when a job actually runs. A trigger-level paths: filter skips the entire workflow, leaving required checks unsatisfied and blocking PRs. The job-level approach keeps the workflow running but skips expensive jobs internally.

Test plan

Open a PR touching only a .md file → lint, build-check, test-units-and-cover, test-integrations-and-cover show as Skipped (green) in Checks
Open a PR touching a file in src/ → all jobs run normally
Push directly to main → commit-lint is skipped, changesets.yml runs as before
Trigger workflow_dispatch → all jobs run (path-filter returns true with no diff)

🤖 Generated with Claude Code

Add dorny/paths-filter gate so lint, build-check, and both test jobs only run when source-affecting files change (src/, test/, package.json, tsconfigs, Dockerfiles, etc.). Metadata checks (commit-lint, changeset-check) remain unconditional. Also restrict commit-lint to PRs/workflow_dispatch to avoid false positives on squash-merge commits pushed to main, fix post-tests Coveralls parallel-finished to not fire on skipped test runs, and bump actions/checkout + actions/setup-node from v3 to v4.

changeset-bot · 2026-04-22T10:08:07Z

⚠️ No Changeset found

Latest commit: 924421f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coveralls · 2026-04-22T10:12:19Z

coverage: 64.937% (-0.01%) from 64.948% — chore/optimize-ci-path-filters into main

Copilot

Pull request overview

Updates CI to avoid running expensive lint/build/test jobs when a PR only changes non-source files, while keeping required checks satisfied and reducing Coveralls noise.

Changes:

Add a changes job (paths filter) and gate lint, build-check, and test jobs on needs.changes.outputs.src.
Restrict commit-lint to pull_request and workflow_dispatch; guard Coveralls “parallel-finished”.
Bump actions/checkout / actions/setup-node to v4 and add @changesets/changelog-github to devDependencies.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File	Description
`.github/workflows/checks.yml`	Adds changed-path detection and conditions to skip expensive jobs; updates action versions; adjusts Coveralls signaling.
`package.json`	Adds `@changesets/changelog-github` devDependency; normalizes author string.
`package-lock.json`	Locks dependencies added by `@changesets/changelog-github`.
`.changeset/proud-pants-cry.md`	Adds a changeset entry for the PR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-22T10:18:20Z

+      needs.lint.result != 'failure' &&
+      needs.build-check.result != 'failure'


The unit test job condition allows execution when lint/build-check are cancelled (because it only blocks failure). If the intent is to only run tests after those jobs succeed, change the condition to require needs.lint.result == 'success' and needs.build-check.result == 'success'.

Suggested change

needs.lint.result != 'failure' &&

needs.build-check.result != 'failure'

needs.lint.result == 'success' &&

needs.build-check.result == 'success'

Copilot · 2026-04-22T10:18:21Z

+    if: |
+      always() &&
+      needs.changes.outputs.src == 'true' &&
+      needs.lint.result != 'failure' &&
+      needs.build-check.result != 'failure'


Same as the unit test job: the integration test job condition only blocks on failure, so tests may still run if lint/build-check were cancelled. If dependencies must pass, require needs.lint.result == 'success' and needs.build-check.result == 'success' instead.

Copilot · 2026-04-22T10:18:21Z

+      - name: Coveralls Finished
+        uses: coverallsapp/github-action@master
+        if: |
+          needs.test-units-and-cover.result != 'skipped' ||
+          needs.test-integrations-and-cover.result != 'skipped'
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          parallel-finished: true


coverallsapp/github-action@master is a floating ref, which is risky for supply-chain security and can introduce unexpected CI changes. Pin this to a stable release tag or (preferably) a commit SHA.

Copilot · 2026-04-22T10:18:22Z

+    outputs:
+      src: ${{ steps.filter.outputs.src }}
+    steps:
+      - uses: actions/checkout@v4


dorny/paths-filter relies on git history for non-PR events (e.g., push), but actions/checkout here uses the default shallow clone. Configure actions/checkout with an appropriate fetch-depth (commonly 0 or at least 2) so the action can diff github.event.before..after reliably.

Suggested change

- uses: actions/checkout@v4

- uses: actions/checkout@v4

with:

fetch-depth: 0

cameri · 2026-04-26T11:06:54Z

@copilot address all the inline comments/reviews

…ness Agent-Logs-Url: https://github.com/cameri/nostream/sessions/5e3c60f2-1798-47a5-b25a-45c990bfb6bd Co-authored-by: cameri <378886+cameri@users.noreply.github.com>

Copilot · 2026-04-26T11:08:42Z

@copilot address all the inline comments/reviews

All five inline review comments addressed in commit 05334c5:

changes job permissions — added contents: read alongside pull-requests: read so actions/checkout isn't silently denied.
changes job checkout depth — added fetch-depth: 0 so dorny/paths-filter can diff before..after on push events.
Unit test condition — changed from != 'failure' to == 'success' for both lint and build-check, removing the always() wrapper so cancelled upstream jobs no longer allow tests to run.
Integration test condition — same == 'success' tightening applied.
Coveralls action pin — replaced the floating @master ref with @v2.3.6 (current stable release) in all three usages (test-units-and-cover, test-integrations-and-cover, and post-tests).

Resolves conflicts by: - Keeping path filter optimization (changes job + conditional skipping) - Adopting pnpm package manager from main - Upgrading GitHub Actions to v4 for security/performance - Updating lock file path from package-lock.json to pnpm-lock.yaml - Changing npm commands to pnpm equivalents - Removing redundant npm-based changeset entry

phoenix-server added 2 commits April 21, 2026 22:00

chore(ci): install missing changelog package

9645553

cameri requested a review from Copilot April 22, 2026 10:14

Copilot started reviewing on behalf of cameri April 22, 2026 10:15 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Copilot started work on behalf of cameri April 26, 2026 11:07 View session

fix(ci): address reviewer feedback on checks.yml security and correct…

05334c5

…ness Agent-Logs-Url: https://github.com/cameri/nostream/sessions/5e3c60f2-1798-47a5-b25a-45c990bfb6bd Co-authored-by: cameri <378886+cameri@users.noreply.github.com>

Copilot finished work on behalf of cameri April 26, 2026 11:09

phoenix-server mentioned this pull request May 7, 2026

Optimize CI: skip expensive jobs on non-source changes #612

Closed

cameri merged commit 6c8e29a into main May 7, 2026
16 of 18 checks passed

cameri deleted the chore/optimize-ci-path-filters branch May 7, 2026 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): skip expensive jobs on non-source changes#565

chore(ci): skip expensive jobs on non-source changes#565
cameri merged 4 commits intomainfrom
chore/optimize-ci-path-filters

cameri commented Apr 22, 2026

Uh oh!

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

coveralls commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

cameri commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		needs.lint.result != 'failure' &&
		needs.build-check.result != 'failure'

Conversation

cameri commented Apr 22, 2026

Summary

Why job-level filter instead of trigger-level paths:

Test plan

Uh oh!

changeset-bot Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coveralls commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

cameri commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Why job-level filter instead of trigger-level `paths:`

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

coveralls commented Apr 22, 2026 •

edited

Loading