Repository navigation
Move Loom tests, API, FHIR, and deploy files out of the root - #213
Merged
Merged
Conversation
Move root fixtures, the compiler conformance package, browser specs, and script tests. Resolve root fixtures through the module root and keep standalone Go scripts paired with their tests during explicit-file runs. Passed make test-go, test-scripts, conformance, openapi-check, lint-go-comments, and the full package audit. The conformance package audits passed before and after its move. Both explicit Go script pairs passed, Node discovery stayed at nine files, and all 72 Node tests passed. make generate produced no diff. make test-ui passed 111 of 112 files. The unchanged Explorer View Builder tests failed with a React hook dispatcher error.
Move the OpenAPI contract, templates, and bindings to api. Move the graph schema and generated FHIR packages to fhir. Update imports, generator paths, image inputs, checks, and documentation. Passed make test-go, test-scripts, conformance, openapi-check, lint-go-comments, and the full package audit. All three focused package audits passed before and after the moves. Node discovery stayed at nine files. make generate left no diff. Schema, edge extraction, and OpenAPI output bytes match the prior commit. Generated FHIR metadata differs only in the package declaration. make test-ui passed 111 of 112 files. The Explorer View Builder React hook dispatcher failure recurred.
Move Compose files and the local stack guide into deploy. Move the dev container and Air files into deploy/dev. Pass the project directory explicitly to preserve root-relative resolution and keep acceptance performance compatible with pre-layout Git snapshots. Passed make test-go, test-scripts, conformance, openapi-check, lint-go-comments, and the full package audit. Node discovery stayed at nine files and make generate left no diff. The earlier-checkout fixture and schema fallback passed a focused launcher check. All four Compose configs passed. Isolated make dev, dev-down, demo-up, demo-smoke, and demo-down passed. make test-ui passed 111 of 112 files and repeated the Explorer View Builder React hook failure.
matthewpeterkort
force-pushed
the
chore/root-layout
branch
from
November 18, 2026 03:40
ec2a2e1 to
a3f88be
Compare
Passed repository launcher, demo configuration, acceptance cleanup, and dev script tests. All four Compose configurations and isolated dev and seeded demo lifecycle checks passed.
Require an explicit query request and use the existing conformance fixture for default profiling. Passed make test-go, make conformance, and make lint-go-comments. Verified the missing-request error and AQL generation with the default fixture.
Run Node, shell, and Python checks with shared setup. Verified the workflow keeps the same run commands and leaves other jobs unchanged. The local shell cleanup check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/. Resolve shared Go fixtures from the module root.api/and the FHIR graph schema and generated packages tofhir/. Schema and edge extraction bytes are unchanged.deploy/. Preserve root-relative Compose resolution with--project-directoryand retain acceptance support for older source revisions.Verification
make test-go,make test-scripts,make conformance,make openapi-check,make lint-go-comments, and the full package audit. Focused audits passed before and after the package moves.make generateleft no diff in all three phases. Node discovery stayed at nine files. All 72 discovered Node tests and both explicit Go script test pairs passed in Phase 1.make dev,make dev-down,make demo-up,make demo-smoke, andmake demo-downpassed.make test-uipassed 111 of 112 files in each phase. The unchanged Explorer View Builder suite failed with a React hook dispatcher error. An isolated pre-move snapshot also failed in that suite.