Repository navigation
Add Builder column rules for imported recipes - #212
Merged
matthewpeterkort merged 12 commits intoNov 17, 2026
Merged
matthewpeterkort merged 12 commits into
matthewpeterkort merged 12 commits into
Conversation
Repair baseline Pivot and Calculate test drivers. Verification: Explorer and recipe Go suites, server and compiler Go suites (server Date-header probe passed on retry), make test-ui (1567 tests), dev-doctor and Identifier Chrome spec. Production diff covered by three scoped adversarial reviews.
Checks: make generate; go test ./internal/explorer/... ./internal/dataframe/recipe/...; make test-ui (1567 tests); dev-doctor and the focused Identifier Chrome spec; OpenAPI kind-arm validation. Interrogate: three scoped gpt-6.1-sol reviews; corrected OpenAPI kind-arm correlation and reran the reproducer and browser. Reviewed final staged patch SHA256 94175a927ac2913aa2d4487222b115f77edb9fc2f9bc227f618fcc7a3a41983b.
Checks: server and recipeimport package audits before and after; package audit --full passed with loopback access; direct dependencies unchanged; Explorer and recipe Go suites; make test-ui (1567 tests); dev-doctor and Identifier Chrome spec passed on retry. Three scoped gpt-6.1-sol interrogate reviews found no confirmed regressions. Reviewed staged SHA256 80ec69e9cb24728abeb8756b972d9d68430bf91dca4ab3fb84391107aee897a3.
Checks: go test ./internal/explorer/... ./internal/dataframe/recipe/...; focused server Graph Connect creation, rename, and removal test; make test-ui (1567 tests); dev-doctor and Identifier Chrome spec. Interrogate: three scoped gpt-6.1-sol reviews and follow-up root-selector compatibility review. Reviewed staged patch SHA256 cf79435aed830fd0ec6d9e7bb72c795bf30acb2572860e8cd6cc9f0ab3b6308d.
Checks: make generate; Explorer and recipe Go suites plus FHIR schema; make test-ui (1567 tests); dev-doctor and Identifier Chrome spec. Three scoped gpt-6.1-sol interrogate reviews found a catalog naming validation gap; follow-up review and regression test verified the fix. Reviewed staged SHA256 aa52e2829518ded1442a5dd66efb9419eb1a3f98038ca26a6948615a8fd64c6e.
Checks: Explorer and recipe Go suites; make test-ui (1569 tests); dev-doctor and Identifier Chrome spec covering cancel-safe preview, saved step edit, disable and re-enable with generated-column restoration. Three scoped gpt-6.1-sol interrogate reviews and a legacy recovery follow-up. Reviewed staged SHA256 2f40478b990d8c8d4fe8524d601819d6a36d36ff5a611e787112d4d829e0dea7.
Checks: Explorer and recipe Go suites; make test-ui (1570 tests); dev-doctor and both Identifier browser cases, including per-column pairing and reload on a Graph Connect occurrence. Interrogate: scoped inventory, related submission, browser fixture and follow-up hook-order reviews. Reviewed staged SHA256 2e32ad5c421ff10ec014828d99d140ff03fe0f8fb3865880373322281f5f6812.
Checks: Explorer and recipe Go suites; focused preset-apply and sibling-array rejection checks; make test-ui (1571 tests); dev-doctor and Category Coding Chrome spec with exact paired cells. Interrogate: three scoped gpt-6.1-sol reviews. Strengthened the browser oracle to reject cross-product cells. Reviewed staged SHA256 6a7ce573f29b0be383c33ed593a8f1d9cb6d9c37fcf8e05adee87d19b526a41f.
Checks: Explorer and recipe Go suites; focused catalog rediscovery and receipt checks; make test-ui (1573 tests); dev-doctor and catalog Chrome spec passed on retry. Interrogate: three scoped gpt-6.1-sol reviews identified missing Builder form wiring, corrected and verified in Chrome. Reviewed staged SHA256 5b18d1f905bdfd31cef32d4f6e9f14a532a4fd207dd855f3f54d52cc5d4bda1b.
Preserve legacy frozen nested mappings and require complete ancestry for new Builder rules. Cover root and traversal authoring, native Boolean projection and identical child URLs under different parents. Verified: Explorer, recipe, compiler, semantic and FHIR Go suites; focused legacy compiler test; make test-ui (1574); dev-doctor and extension-column-rule Chrome acceptance; pstack:interrogate with same-model compiler, discovery and authoring reviews plus compatibility recheck.
Keep all four presets browseable and describe their output. Disable rules with type-wide inventory reasons or occurrence-specific catalog and removal reasons. Verified: Explorer and recipe Go suites; make test-ui (1574); dev-doctor and five Chrome cases across Identifier, Extension, Category coding and Catalog rules. pstack:interrogate same-model ownership and UI reviews found no confirmed defects at staged diff SHA-256 4b2407011366b567dbaf7626ab443536156382fec65999eebddfc9cc6a57cd2c.
Use shared pinned field validation and accept valid object owners for Extension pivots. Retain the Add columns panel by occurrence and preserve cosmetic field editing. Verified server tests, 1593 UI tests, and five focused Chrome cases across the four rule types.
matthewpeterkort
merged commit Nov 17, 2026
437bf71
into
feature/default-recipe-authoring
7 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6a9bea526and reuse its correlated Extension compiler and output overrides.Verification
artifactfs. The unchangedartifactfspackage timed out inTestReconcileRetainsSetWhenRecordBecomesUnreadableUnderLock.make test-uipassed all 1,593 tests.dev-doctorand five focused Chrome cases passed across the four column rule kinds on an isolated development stack. Category passed on rerun after adding an explicit wait for the saved occurrence.Legacy drafts with frozen nested Extension mappings that omit ancestor URLs remain subject to the base compiler's exact ancestry requirement. The saved Extension editor currently retains the selected source path.