Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/releases/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ When a change has user-facing documentation, include a canonical tasknotes.dev l

## Fixed

- (#2301) Fixed clicking the Pomodoro timer display to edit its duration. Thanks to @minnyee for reporting and identifying the cause.

- (#2328) Fixed direct status edits on occurrence notes not updating the recurring parent’s completion history or creating the next occurrence when configured. Thanks to @mudnug for reporting this.
2 changes: 2 additions & 0 deletions styles/pomodoro-view.css
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@

/* Timer Display */
.tasknotes-plugin .pomodoro-view__timer-display {
pointer-events: auto;
font-size: 3.5rem;
color: var(--tn-text-normal);
text-align: center;
Expand All @@ -141,6 +142,7 @@
}

.tasknotes-plugin .pomodoro-view__timer-input {
pointer-events: auto;
width: 5.5em;
border: none;
border-radius: var(--tn-radius-sm);
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/issues/issue-2301-pomodoro-pointer.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import fs from "fs";
import path from "path";

const css = fs.readFileSync(path.resolve(__dirname, "../../../styles/pomodoro-view.css"), "utf8");

function block(name: string): string {
return css.match(new RegExp(`\\.tasknotes-plugin \\.pomodoro-view__${name}\\s*\\{([^}]*)\\}`))?.[1] ?? "";
}

describe("Issue #2301: Pomodoro duration pointer targets", () => {
it.each(["timer-display", "timer-input"])("restores pointer targeting on %s", (name) => {
expect(block(name)).toMatch(/pointer-events:\s*auto;/);
});

it("keeps the overlay click-through and adjustment buttons interactive", () => {
expect(block("timer-overlay")).toMatch(/pointer-events:\s*none;/);
expect(block("time-controls")).toMatch(/pointer-events:\s*auto;/);
});
});
Loading