docs: align docs with code on MCP tool exposure, scheme discovery, and build variants - #78
Merged
Merged
Conversation
…d build variants
Nine doc/code inconsistencies, verified against packages/ before editing:
1. README said app tools "show up next to the agent's own" over MCP. They are
never registered as MCP tools (mcp/app-tools.ts) — an agent reaches them via
appduct_list_tools / appduct_describe_tool / appduct_call_tool.
2. Scheme discovery also reads Android build.gradle(.kts)/AndroidManifest.xml
and iOS Info.plist/project.yml (native-scheme.ts), not just app.json. Updated
the `init --scheme` / `link --scheme` help text, ARCHITECTURE §10 and the
appduct skill (SKILL.md and references/setup.md), including that two probes
resolving different schemes is an error rather than a guess.
3. TOOLS.md described a createAppductClient defaultToolTimeoutMs option;
CreateAppductClientOptions is Record<string, never> and the fallback is
native-owned.
4. ARCHITECTURE §11 said sessionChange carries only { sessionId, alias }; the
event is { type, sessionId, alias, reason? }.
5. metro.d.ts documented `include` as defaulting to true and mirroring the
config plugin's removed `include` option; metro.js defaults to
APPDUCT_ENABLED.
6. playground/README told readers to run `expo run:ios` from the monorepo root,
but expo is a playground dependency.
7. TOOLS.md intro referred to "the shape MCP requires"; app schemas no longer
travel as MCP inputSchema.
8. SECURITY.md said Android swaps in a no-op AppductPackage for release.
android/build.gradle swaps the vendored core source directory
(core vs core-noop); AppductPackage always compiles. BUILD-VARIANTS.md was
already correct.
9. skills/appduct/references/setup.md numbered two steps "6.".
pnpm check:links, typecheck and test all pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GmJYxaqiwgZqLooLjYQXBt
V3RON
added a commit
that referenced
this pull request
Sep 21, 2026
V3RON
added this pull request to stack #79
September 21, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nine doc/code inconsistencies. Each was verified against
packages/(the source of truth) before editing; no behavior changes, only documentation and two CLI help strings.What was wrong, and what the code says
README.mdclaimed app tools "show up next to the agent's own" over MCP.packages/appduct/src/mcp/app-tools.ts:3is explicit that they are never registered as MCP tools — an agent reaches them throughappduct_list_tools/appduct_describe_tool/appduct_call_tool. (packages/appduct/README.md:215already said this correctly.)Scheme discovery also reads Android
app/build.gradle(.kts)/app/src/main/AndroidManifest.xmland iOSInfo.plist/project.yml(native-scheme.ts), andinitreaches those probes too viadiscoverStaticProjectScheme. Onlyapp.jsonwas documented. Updated theinit --schemeandlink --schemehelp text,docs/ARCHITECTURE.md§10 (item 5 is now the full a/b/c probe order), and the appduct skill (SKILL.md,references/setup.md), including the rule that two probes resolving different schemes is an error rather than a guess. Also corrected §10's twoinit --force/ divergence sentences, which still namedapp.jsonalone.docs/TOOLS.mddocumented acreateAppductClientdefaultToolTimeoutMsoption.CreateAppductClientOptionsisRecord<string, never>; the app-side fallback is native-owned (APPDUCT_DEFAULT_TOOL_TIMEOUT_MS) with no TurboModule channel for JS to override it.docs/ARCHITECTURE.md§11 saidsessionChangecarries only{ sessionId, alias }and no longer distinguishes a claim from a resume from a loss.AppductSessionChangeEventis{ type, sessionId, alias, reason? }.packages/react-native/metro.d.tsdocumentedincludeas defaulting totrueand mirroring the config plugin'sincludeoption.metro.js:96falls back toisAppductAutolinkEnabled()(APPDUCT_ENABLED), andapp.plugin.js:94throws onincludeas removed.playground/README.mdtold readers to runpnpm exec expo run:iosfrom the monorepo root;expois a dependency of the playground app.docs/TOOLS.mdintro referred to "the shape MCP requires"; app schemas no longer travel as MCPinputSchema. The file's other MCP mentions (tool groups,appduct_describe_tool,timeout_ms) are accurate and untouched.docs/SECURITY.mdvsdocs/BUILD-VARIANTS.mddisagreed about Android. BUILD-VARIANTS is correct:packages/react-native/android/build.gradle:75-79swapsjava.srcDirsbetween the vendoredcoreandcore-noop, andAppductPackage.ktlives insrc/main/javaand compiles for every variant. SECURITY.md's "swaps in a no-opAppductPackage" was fixed.skills/appduct/references/setup.mdnumbered two steps6.; thegetAppductState()item is now8., matching the surrounding 7/9/10.website/src/content/docsdoes not exist in this repository, so there was nothing to keep in sync there.Verification
pnpm check:links— clean, 38 Markdown files, no broken relative links or anchorspnpm -w typecheck— passespnpm -w test— 739 passed, 1 skipped🤖 Generated with Claude Code
https://claude.ai/code/session_01GmJYxaqiwgZqLooLjYQXBt
Generated by Claude Code