fix(queue): preserve dtoClass through failed jobs and requeue - #196
Merged
Merged
Conversation
Failed jobs dropped the DTO marker: FailedJobsListener persisted only data + requeueOptions, and RequeueCommand re-pushed without dtoClass, so a requeued DTO job came back as a plain array and getDto() could no longer rehydrate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(queue): preserve dtoClass through failed jobs and requeue
Problem
Failed jobs silently dropped the DTO marker:
FailedJobsListenerpersisted only
data+requeueOptions, andRequeueCommandre-pushed without
dtoClass. A requeued DTO job came back as aplain array and
Message::getDto()could no longer rehydrate it.Changes
AddDtoClassToFailedJobs: nullabledto_classonqueue_failed_jobs(legacy rows unaffected)FailedJobsListenerstoresbody['dtoClass']intodto_class(
nullfor legacy bodies without the key)RequeueCommandpassesdto_classback as thepush()dtoClassoption (
null= previous behaviour, nothing added to the body)FailedJobentity/table:$_accessible, validation, phpdoc;tests/schema.php+FailedJobsFixturerecords updated