Skip to content

4.x - Update to Rector 2.8.4 - #825

Merged
dereuromark merged 1 commit into
cakephp:4.xfrom
bancer:4.x-upgrade-rector-2.8.4
Nov 9, 2026
Merged

dereuromark merged 1 commit into
cakephp:4.xfrom
bancer:4.x-upgrade-rector-2.8.4

Conversation

@bancer

@bancer bancer commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Rector 2.7.0 bundles an older phpstan/phpdoc-parser that conflicts with PHPStan 2.3.5, causing rector process to fail with a CallableTypeNode::__construct() type error. Rector 2.8 requires phpstan ^2.3.5 and works with it.

  • Bump rector/rector to ~2.8.4 in the rector-setup script.
  • Remove ObjectExplicitBoolCompareRector from skipped rules, as it is deprecated and no longer registered.
  • Apply ExplicitNullableObjectInstanceRector to AuthenticationMiddleware.

Rector 2.7.0 bundles an older phpstan/phpdoc-parser that conflicts with
PHPStan 2.3.5, causing `rector process` to fail with a
CallableTypeNode::__construct() type error. Rector 2.8 requires
phpstan ^2.3.5 and works with it.

* Bump rector/rector to ~2.8.4 in the rector-setup script.
* Remove ObjectExplicitBoolCompareRector from skipped rules, as it is
  deprecated and no longer registered.
* Apply ExplicitNullableObjectInstanceRector to AuthenticationMiddleware.
@dereuromark
dereuromark merged commit 2993e7d into cakephp:4.x Nov 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants