Repository navigation
fix(deps): drop spring-boot-starter-web and unused commons-configuration - #297
Merged
vladimir-gavrilenko merged 1 commit intoOct 22, 2026
Conversation
**Which sample(s) or area?** Build (build.gradle), spring and hello samples **What changed?** - Replaced `spring-boot-starter-web` with `spring-boot-starter`. - Bumped the Spring Boot plugin from 2.7.15 to 2.7.18. - Removed `commons-configuration`. - Declared `commons-lang3` and `jackson-annotations` explicitly, since they were only on the classpath transitively. `HelloSignal` and `HelloSignalAndResponse` now import `RandomStringUtils` from lang3. **Why?** Most Snyk findings come from the transitive dependencies of `spring-boot-starter-web` (Tomcat, spring-web, spring-webmvc). The spring sample uses no web features. **How did you test it?** - `./gradlew build` on JDK 11: BUILD SUCCESSFUL. - Count unique Snyk issues per severity, on master and on this branch: `snyk test --org=cadence --json | jq -r '[.vulnerabilities[]] | unique_by(.id) | group_by(.severity)[] | "\(.[0].severity) \(length)"'` **Potential risks** Low. Code relying on embedded Tomcat or Spring MVC would break, but nothing in `src` does. **Release notes** N/A **Documentation Changes** N/A Signed-off-by: Vladimir Gavrilenko <vladi.a.gavri@gmail.com>
Code Review ✅ Approved🟡 Medium risk · Replacing the web starter with the core starter may break sample behavior that depends on Spring MVC or embedded Tomcat. Drops VerificationFunctional validation No results Rules 1 not applicable For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
AndreasHolt
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which sample(s) or area?
Build (build.gradle), spring and hello samples
What changed?
spring-boot-starter-webwithspring-boot-starter.commons-configuration.commons-lang3andjackson-annotationsexplicitly, since they were only on the classpath transitively.HelloSignalandHelloSignalAndResponsenow importRandomStringUtilsfrom lang3.Why?
Most Snyk findings come from the transitive dependencies of
spring-boot-starter-web(Tomcat, spring-web, spring-webmvc). The spring sample uses no web features.How did you test it?
./gradlew buildon JDK 11: BUILD SUCCESSFUL.snyk test --org=cadence --json | jq -r '[.vulnerabilities[]] | unique_by(.id) | group_by(.severity)[] | "\(.[0].severity) \(length)"'Potential risks
Low. Code relying on embedded Tomcat or Spring MVC would break, but nothing in
srcdoes.Release notes
N/A
Documentation Changes
N/A