Repository navigation
Conversation
Signed-off-by: michboy <michboy@umich.edu>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #823.
The LFM2 tool-call parser can enter an infinite loop when processing malformed arguments with mismatched closing brackets, potentially causing unbounded memory growth.
This PR prevents the parser from getting stuck on malformed input.
Changes
py_literal_to_json().nullfor empty scalar values.extract_lfm2_tool_calls().Testing
Added
cactus-engine/tests/test_chat_tools_823.cppwith four standalone C++ regression tests.Local test results pending verification.
Attribution
The fix follows the approach originally proposed by @Rasaboun in #823, with regression tests added.