Repository navigation
fix(graph): remove duplicate GraphFile namespace declaration - #799
Open
nimakalantar wants to merge 1 commit into
Open
nimakalantar wants to merge 1 commit into
nimakalantar wants to merge 1 commit into
Conversation
`MappedFileRegistry` is already inside `GraphFile`, so the nested namespace caused its definitions to resolve incorrectly and broke the build. Signed-off-by: Nima Kalantar <nima.kalantar@focusrite.com>
nimakalantar
force-pushed
the
fix-build
branch
from
August 29, 2026 12:22
5ee8e0a to
fcbd1bf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a C++ namespace scoping error in cactus-graph where MappedFileRegistry was inadvertently placed under a duplicated GraphFile namespace (GraphFile::GraphFile::...), causing symbol resolution failures and breaking the build.
Changes:
- Removed the redundant nested
namespace GraphFile { ... }wrapper around theMappedFileRegistrydefinitions so they correctly remain inGraphFile. - Minor whitespace cleanup near an anonymous-namespace closing brace.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MappedFileRegistryis already insideGraphFile, so the nested namespace caused its definitions to resolve incorrectly and broke the build.