Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--calibration-manifeston the publiccactus convertcommand and forward it through local CQ conversionRoot cause
The internal converter already accepted calibration manifests, but the public CLI did not expose or forward the option. This made finetuned Needle conversions run without representative activation data. In addition, cached bundles could bypass calibration silently, and positive-sample Hessians that could not be applied fell back to RTN without a visible warning.
Impact
Finetuned checkpoints can now supply representative language data through the supported CLI. Conversion summaries distinguish successful GPTQ calibration from both zero-sample and unusable-Hessian fallbacks, making accidental RTN conversion visible and actionable.
Validation
PYTHONPATH=python python3 -m pytest python/tests/test_cli_calibration.py python/cactus/convert/tests -q(77 passed)E401,F401,F841)python3 -m compileall -q python/cactus/cli python/cactus/convert python/tests/test_cli_calibration.pygit diff --checkFixes #767