ci: delete unreachable npm-token publish jobs from build-wasm and build-native (LAB-1390) - #97
ci: delete unreachable npm-token publish jobs from build-wasm and build-native (LAB-1390)#9727Bslash6 wants to merge 1 commit into
Conversation
…ld-native (LAB-1390) Both tag-gated publish jobs were doubly dead: the repo has no NPM_TOKEN secret (LAB-831), and GitHub App-created release tags never trigger these workflows anyway. build-wasm's publish had exactly one lifetime run — the manually pushed cachekit-core-wasm-v0.1.1 tag — and it failed ENEEDAUTH; the package actually published via release-please.yml's pnpm OIDC job. build-native's publish never ran once: cachekit-core-ts 0.1.0 and 0.1.2 were both manual publishes (no provenance attestations). Wasm publishing (release + wasm_tag recovery dispatch) is fully covered by release-please.yml. Native publishing stays manual until a working CI path is designed (follow-up ticket); headers document both realities and the napi version-sync gotcha so the knowledge survives the deletion.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe CI workflows now build and validate native and Wasm packages without publishing them. Comments document manual native publishing, release-please behaviour, recovery tags, and GitHub App-created tag limitations. ChangesCI publishing control
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
This PR removes dead, unreachable npm publish jobs from two CI workflows and documents why publishing is handled elsewhere.
Changes
.github/workflows/build-native.ymlpublishjob that was gated oncachekit-core-ts-v*tags. This job never actually ran: GitHub App-created release tags don't trigger the workflow, and the repo has noNPM_TOKENsecret, so it would have failed withENEEDAUTHregardless.mainand on manually pushedcachekit-core-ts-v*tags, feeding the (currently manual) publish process..github/workflows/build-wasm.ymlpublishjob (and theUpload artifactstep it depended on). This job also could not authenticate — its single lifetime run failed withENEEDAUTH.release-please.yml'spublish-cachekit-core-wasmjob using pnpm OIDC trusted publishing..github/workflows/release-please.ymlcachekit-core-tsoutputs are currently unconsumed, since App-created tags don't triggerbuild-native.ymland core-ts publishing remains manual.Impact
release-please.yml, and core-ts publishing remains manual.Summary by CodeRabbit