Skip to content

test(core): re-vendor bin16 width-boundary vectors (LAB-868) - #70

Open
27Bslash6 wants to merge 3 commits into
mainfrom
agent/codex-luna/3264b19f
Open

test(core): re-vendor bin16 width-boundary vectors (LAB-868)#70
27Bslash6 wants to merge 3 commits into
mainfrom
agent/codex-luna/3264b19f

Conversation

@27Bslash6

@27Bslash6 27Bslash6 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Re-vendors the protocol wire-format 1.1.1 fixture after the new real-writer bin16 boundary pair landed.

  • updates FIXTURE_SHA256 and protocol provenance commit
  • updates the fixture revision assertion
  • keeps the fixture append-only and cross-SDK readable

LAB-868

Summary by CodeRabbit

  • Bug Fixes

    • Improved wire-format handling for binary payloads of varying sizes, including transitions at 255/256 bytes.
    • Ensured payloads use the most compact supported binary marker (bin8, bin16, or bin32).
  • Tests

    • Expanded protocol coverage with larger, incompressible payload fixtures.
    • Added validation for legacy and current wire-format vectors.
    • Maintained the limit of no more than one additional byte of wire overhead.

@kodus-27b

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ba040780-bb4d-4d9a-8985-1f906a0f7855

📥 Commits

Reviewing files that changed from the base of the PR and between 60efc84 and 5661503.

📒 Files selected for processing (1)
  • tests/wire_format_vectors.rs

Walkthrough

Changes

The tests now validate the shortest MessagePack binary marker for compressed payloads. Fixtures add a 300-byte bin16 boundary vector and its binary twin. Fixture metadata and checksums now reference version 1.1.1.

Wire-format validation

Layer / File(s) Summary
Fixture boundary vectors
tests/vectors/wire-format.json, tests/wire_format_vectors.rs
Added the bin16 boundary vector and twin. Updated fixture provenance, version, commit hash, and checksum.
Marker-width validation
tests/dual_decode.rs, tests/wire_format_vectors.rs
Validation now accepts bin8, bin16, or bin32 according to compressed payload length. Tests require matching legacy and binary-vector counts.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: kodus-27b

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the test change, re-vendored bin16 boundary vectors, and related issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/codex-luna/3264b19f

Comment @coderabbitai help to get the list of available commands.

kodus-27b[bot]
kodus-27b Bot previously approved these changes Aug 7, 2026
@kodus-27b

This comment has been minimized.

kodus-27b[bot]
kodus-27b Bot previously approved these changes Aug 7, 2026
@27Bslash6

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/wire_format_vectors.rs`:
- Around line 101-104: Update the vector coverage assertions around the
legacy/bin counts to build occurrence counts keyed by each entry’s derived_from
value, then require exactly one *_bin twin for every legacy vector and reject
duplicates or missing parents. Preserve the existing total checks, and
explicitly assert that both width_boundary_bin16 and width_boundary_bin16_bin
entries are present.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d089bc23-8d3a-4cd7-b765-485357a20022

📥 Commits

Reviewing files that changed from the base of the PR and between 11bb346 and 60efc84.

📒 Files selected for processing (3)
  • tests/dual_decode.rs
  • tests/vectors/wire-format.json
  • tests/wire_format_vectors.rs

Comment thread tests/wire_format_vectors.rs Outdated
Equal legacy/bin totals admit duplicate twins and orphaned parents, and
never pin the LAB-868 width-boundary pair by name. Key every *_bin
vector by derived_from, require exactly one twin per legacy vector, and
assert width_boundary_bin16 + width_boundary_bin16_bin explicitly.

CodeRabbit-Resolved: wire_format_vectors.rs:101:Enforce one-to-one twin cover
@kodus-27b

kodus-27b Bot commented Aug 8, 2026

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

Comment thread tests/wire_format_vectors.rs

@kodus-27b kodus-27b Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found critical issues please review the requested changes

@27Bslash6

Copy link
Copy Markdown
Contributor Author

@kody start-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant