fix(cli): baseline path join + per-statement EXPLAIN - #26
Merged
Merged
Conversation
- Join git_repo when mapping baseline-discovered relative paths so audit works when CWD is the config directory (#24) - Run file_diff under repo_path for consistent --diff-aware behavior - Split multi-statement SQL via ogsql-parser and EXPLAIN each DML statement independently; failures no longer abort the whole file (#25) - clippy: use slice::contains in cr-core filter Closes #24 Closes #25
CodeRoughcollie 多项目审核报告总览
项目: self执行摘要
✅ 审核通过,未发现问题。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs found during UserGuide × testcases verification:
fix(cli): join git_repo when resolving baseline-discovered file paths #24 — Baseline-discovered files are repo-relative; when
git_repois not.(e.g.c2j/ogagila), reads failed withNo such file. Paths are now joined withgit_repo.file_diffruns underrepo_pathso--diff-awarestays consistent.fix(cli): run EXPLAIN per SQL statement, not whole multi-statement file #25 — Multi-statement SQL files ran a single EXPLAIN on the whole file; one failure aborted all plan analysis. Statements are split via
ogsql-parserand each explainable DML is EXPLAINed independently (per-statement failures only warn).Also: clippy
manual_containsincr-corefilter (CI hygiene).Test plan
cargo test -p cr-cli(includes new unit tests for path join + statement split)cargo test -p cr-gitcargo clippy -p cr-cli -p cr-git -p cr-core -- -D warnings --no-depsCloses #24
Closes #25