Repository navigation
feat(cdk): retain the static website bucket by default - #57
Merged
Merged
Conversation
Closed
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Owner
Author
|
下記対応して |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
|
Owner
Author
|
基本 override しなくて良い |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
|
There was a problem hiding this comment.
🟢 Approved
No active review issues remain for the website bucket-retention change.
No open issues 🎉
What changed in this PR
This PR addresses #56 by configuring the CDK static website bucket to retain its contents when the stack is deleted or the bucket is replaced.
Changes:
- Switch the website bucket to
RemovalPolicy.RETAINand remove automatic object deletion. - Update assertions and the template snapshot to verify retention and the absence of auto-delete resources.
| File | Description |
|---|---|
cdk/test/cdk.test.ts |
Assert both retention policies and no auto-delete custom resource. |
cdk/test/__snapshots__/cdk.test.ts.snap |
Reflect retention and removal of auto-delete resources and permissions. |
cdk/lib/construct/static-website-construct.ts |
Retain the website bucket and disable automatic object deletion. |
Review effort: Balanced
c19yamamoto
deleted the
copilot/c19yamamoto-56-retain-deletion-policy
branch
November 16, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure the website bucket to retain its contents when the stack is deleted or replaced.
RemovalPolicy.RETAINand disable automatic object deletion.