Repository navigation
fix: e2e: player name test no longer races the htmx poll - #8
Merged
Merged
Conversation
TestE2EPlayerNameIsText waited for td.who with WaitVisible and read it with Text, both of which hold a DOM node id. The htmx poll swaps td.who again, and a swap between the two calls failed the test with "No node with given id found" (it did on main after the 0.8.1 merge, with the same code green on the PR). Poll and read with Evaluate, which needs no node id. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 86.44% 86.41% -0.03%
==========================================
Files 215 215
Lines 21016 21016
==========================================
- Hits 18168 18162 -6
- Misses 2838 2844 +6
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main after the 0.8.1 merge failed in
Browser e2e (trixie):TestE2EPlayerNameIsText->No node with given id found (-32000). The same code was green on the PR, so it is a flake:WaitVisibleandTexthold a DOM node id and the htmx poll can swaptd.whoin between.The test now polls and reads in the page with
Evaluate. Passes 15x with-racelocally. Test-only change, no behaviour or docs change.🤖 Generated with Claude Code