Skip to content

fix: e2e: player name test no longer races the htmx poll - #8

Merged
bzed merged 1 commit into
mainfrom
fix/e2e-player-name-race
Nov 9, 2026
Merged

bzed merged 1 commit into
mainfrom
fix/e2e-player-name-race

Conversation

@bzed

@bzed bzed commented Nov 9, 2026

Copy link
Copy Markdown
Owner

CI on main after the 0.8.1 merge failed in Browser e2e (trixie): TestE2EPlayerNameIsText -> No node with given id found (-32000). The same code was green on the PR, so it is a flake: WaitVisible and Text hold a DOM node id and the htmx poll can swap td.who in between.

The test now polls and reads in the page with Evaluate. Passes 15x with -race locally. Test-only change, no behaviour or docs change.

🤖 Generated with Claude Code

TestE2EPlayerNameIsText waited for td.who with WaitVisible and read it with
Text, both of which hold a DOM node id. The htmx poll swaps td.who again, and
a swap between the two calls failed the test with "No node with given id
found" (it did on main after the 0.8.1 merge, with the same code green on the
PR). Poll and read with Evaluate, which needs no node id.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bzed
bzed merged commit ce7f7b7 into main Nov 9, 2026
11 of 12 checks passed
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (3de402e) to head (6b75ca3).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   86.44%   86.41%   -0.03%     
==========================================
  Files         215      215              
  Lines       21016    21016              
==========================================
- Hits        18168    18162       -6     
- Misses       2838     2844       +6     
  Partials       10       10              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bzed
bzed deleted the fix/e2e-player-name-race branch November 9, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant