Create imports through a factory that picks native or bytecode - #174
Open
andreaTP wants to merge 1 commit into
Open
Create imports through a factory that picks native or bytecode#174andreaTP wants to merge 1 commit into
andreaTP wants to merge 1 commit into
Conversation
andreaTP
commented
Sep 2, 2026
andreaTP
left a comment
andreaTP
left a comment
Contributor
Author
There was a problem hiding this comment.
a couple of comments
| new NameExpr("NativeMachineFactoryProvider"), "discover"))); | ||
| } | ||
|
|
||
| private static void generateImportsMethod(ClassOrInterfaceDeclaration type) { |
Contributor
Author
There was a problem hiding this comment.
Can we remove this generated code in favor of, maybe, another method or an instance method on ImportFactory?
| /** | ||
| * Creates the memories, tables and globals a module imports. | ||
| * | ||
| * <p>Natively compiled code reaches an import through a raw address, so it can only |
Contributor
Author
There was a problem hiding this comment.
This comment is ways too long and it brings history with it which is useless for the user.
Should be very short and just tell the minimum important info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API for redline cleanup/finalization.