Repository navigation
fix(server): accept 1..3 control plane replicas, not only 1 or 3 - #103
Merged
Merged
Conversation
The cluster update validator rejected any control plane replica count that was not 1 or 3, citing an "odd numbers required for etcd quorum" rule. Steward hosts the control plane and does not tie the API server replica count to etcd quorum, so 2 is a valid and useful count. Replace the odd-only check with a 1..3 range and drop the quorum explanation. The existing 3->1 downgrade acknowledgement gate is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cluster update validator rejected any control plane replica count that was not
1or3, with the message "odd numbers required for etcd quorum". Steward hosts the control plane and does not couple the API server replica count to etcd quorum (etcd is a separate, shared datastore), so 2 is a valid and useful replica count (HA without the cost of 3).This replaces the odd-only check with a
1..3range and removes the quorum explanation.1,2,3accepted0,4rejected3 -> 1downgrade-acknowledgement gate is unchangedScope
Validation semantics only — no environment-specific replica policy. Pairs with butlerdotdev/butler-api#49 (provider-owned replicas default) but is independent at the code level (this handler uses its own request DTO).
Test
Updated
clusters_update_test.go: 2 accepted, 3 accepted (scale-up), 4 rejected, 0 rejected, downgrade-ack cases retained.