Repository navigation
Conversation
GET /teams/{name}/providers filtered by scope but never checked who was
asking, so any authenticated user could enumerate another team's
team-scoped providers by naming that team in the path. The scope exists
to keep those providers to their team; the read undid that.
The read now requires CanViewTeam, the weaker of the two team checks, so
every member of the team and any platform role still sees what the team
may use, while a non-member is refused the way the mutations on the same
route already refuse them. The scope filter is extracted and tested on
its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GET /teams/{name}/providersfiltered providers by scope but never checked who was asking. Any authenticated user could enumerate another team's team-scoped providers by naming that team in the path.Proof
Probed on the development estate with a team admin of
platform-engineeringwho is not a member ofe2e-other-team:GET /teams/e2e-other-team/providersanswered 200 and listed the provider scoped toe2e-other-team.The mutations on the same route (
POST,DELETE) already gate onCanOperateTeam.Change
CanViewTeam: every team member and any platform role still reads it; a non-member gets 403 with the same wording the mutations use.providersVisibleToTeamand covered by table tests (platform, unscoped default, own team, other team, team scope without a ref).No behaviour change for callers who could legitimately read the list.
🤖 Generated with Claude Code
https://claude.ai/code/session_01APpgCYzvB1vEntdFm3py2n