Repository navigation
docs(adr): pin mode is exactly one value - #107
Merged
Merged
Conversation
The original §5 mode-semantics text allowed pin to carry one or many Values, with the modal switching between a read-only single entry and a list. That made pin and allowList only differ by the optional Default field, which is a weak distinction the form implementation surfaced as a real UX problem (operators added multiple values to a "pin" rule when they expected a singleton). Update §5 pin definition: Values must have length 1; the modal renders the entry as a single read-only selection. Use allowList when the value count is unbounded; use pin only when the single- value semantics are deliberate. Mode-behavior table row for pin updated to "Yes (single value)" and "Renders read-only" so the orthogonal grid reads cleanly: pin: single value, enforcing default: single value, advisory allowList: multi value, enforcing recommended: multi value, advisory butler-controller webhook (PR #105) enforces len(Values) == 1 for pin. butler-console form (PR #76) renders pin as a single-select. No design change beyond clarifying intent that was already present in the name "pin".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-018 amendment. Same shape as PR #106. No design change beyond clarifying intent that was already present in the name "pin".
Why
The original §5 pin definition allowed pin to carry one or many Values, with the modal switching between a read-only single entry and a list. That made pin and allowList differ only by the optional Default field. The form implementation surfaced this as a real UX problem during visual testing: operators added multiple values to a rule labeled "pin" when they intuitively expected a single value.
Changes
The orthogonal four-mode grid is now clean:
Companion fixes
len(Values) == 1for pin in PR feat(controller): add ClusterCreationPolicy webhook + TenantCluster enforcement #105 (commit6c488ca)c7df30b)Verification