Repository navigation
fix(cluster): cross-platform process detach for the local port-forward - #61
Merged
Merged
Conversation
The local kubeconfig port-forward detached the child with
syscall.SysProcAttr{Setsid: true}, a Unix-only field, which broke the Windows
cross-compile in the release build (the host-only CI test did not catch it).
Move the detach attribute behind build tags (Setsid on Unix, CREATE_NEW_PROCESS_GROUP
| DETACHED_PROCESS on Windows), and add a cross-compile-all-targets step to CI so a
release-breaking compile error fails CI before the release does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the v0.18.0 release failure: the local kubeconfig port-forward used
syscall.SysProcAttr{Setsid: true}(Unix-only), which broke the Windows cross-compile in goreleaser. The host-only CI test job didn't catch it.detach_unix.goSetsid;detach_windows.goCREATE_NEW_PROCESS_GROUP | DETACHED_PROCESS).Verified locally: all 6 GOOS/GOARCH combos build clean.