Repository navigation
fix(crds): refresh embedded CRDs from butler-api v0.17.0 - #35
Merged
Merged
Conversation
The bootstrap controller overlays embedded CRDs from internal/crds/ on top of whatever the butler-crds chart installs, to keep any binary-side type extensions canonical on tenant clusters. After the audit bumped butler-api to v0.17.0, the embedded CRDs were not regenerated. They stayed at the schema shipped before the audit and overwrote the newer chart CRDs at install time. Concrete symptom: butler-addons 0.8.4 install fails with AddonDefinition validation error on spec.category "dns" and unknown fields spec.iconData / spec.tier. butler-crds chart 0.20.0 has the correct schema, but the embedded overlay reverts the AddonDefinition CRD to an older schema before butler-addons attempts to create its resources. Copied 6 CRDs verbatim from butler-api v0.17.0 config/crd/bases: - addondefinitions: adds dns, database, messaging, service-mesh to category enum; adds iconData and tier fields - butlerconfigs: schema additions from v0.13 -> v0.17 - providerconfigs: schema additions - teams: schema additions (largest delta, +345 lines) - tenantaddons: schema additions - tenantclusters: schema additions The embedded CRDs now match butler-api v0.17.0, which matches the butler-crds chart 0.20.0 schema. butler-addons 0.8.4 AddonDefinitions will validate against the live CRD after this lands. Future butler-api bumps must regenerate these embedded CRDs. Surfaced as a finding in ~/code/notes/butler-platform-findings.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.