fix(cache-restore): retry s3 Download on 412#4045
Open
buildkate wants to merge 1 commit into
Open
Conversation
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
I didn’t find any code issues in the S3 GetObject 412 retry path. I’m leaving this as a comment rather than approving because it changes runtime cache restore behaviour, which I read as L2 and there isn’t an L2 approval grant for this PR.
Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 2376, then answer my questions about the findings.
buildkate
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(cache restore): retry s3 GetObject on status
412PreconditionFailedThis error occurs on the s3 multipart downloader when the object's ETtag changes mid-download (which can happen when a concurrent restore's TTL-refresh CopyObject changes the object).
Context
Resolves A-1452
Changes
Retries the s3 GetObject
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Affiliation (optional, external contributors)
Buildkite
Disclosures / Credits
Claude