Fixed mapping of IfcUriReference to backing type#445
Open
CBenghi wants to merge 2 commits intobuildingSMART:developmentfrom
Open
Fixed mapping of IfcUriReference to backing type#445CBenghi wants to merge 2 commits intobuildingSMART:developmentfrom
CBenghi wants to merge 2 commits intobuildingSMART:developmentfrom
Conversation
This makes URIs regex more specific to be valid, while still very loose. Also added minor comment to specifications, to clarify the role of `Instructions` for facets associated with requirements.
The correct name in xml schema documenation has URI all capitals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recognises the specific xs:anyUri type for IfcUriReference.
It also makes URI's regex more specific, while still loose.
Also, a minor minor comment is added in the specifications.md, to introduce the existence of
Instructionsfor facets associated with requirements.