Add ZSTD ReadOffset support - #362
Open
snakethatlovesstaticlibs wants to merge 2 commits into
Open
Conversation
Contributor
|
This bug was identified and fixed in pr #347 as well but as that is a much larger pull request it is likely to need some more time before it is ready to merge. @EdSchouten Any opinion on merging the specific bug fix separately? |
EdSchouten
reviewed
Aug 22, 2026
| } | ||
|
|
||
| func (s *byteStreamServer) Read(in *bytestream.ReadRequest, out bytestream.ByteStream_ReadServer) error { | ||
| if in.ReadLimit != 0 { |
Member
There was a problem hiding this comment.
What's up with this change? I don't think we have any code for respecting this, even for the uncompressed case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #360
AI was used to create this code