Repository navigation
fix(sqlite): close tape store at framework shutdown - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite's worker kept Bub CLI processes alive after returning results.
Yield the cached tape store through the framework lifecycle and always await
store.close()infinally. The store remains reusable in later lifecycles.Validation: one subprocess regression checks two successful CLI calls, a real missing-anchor error, SQLite activation, and natural exit. Ablations fail without cleanup,
finally, or cache reuse, and reject a coroutine-returning hook. Full suite: 688 passed, 3 skipped; SQLite tests on Python 3.12: 20 passed; Ruff and diff checks passed.