fix: normalize BRC-100 bytes across wallet transports - #482
Merged
Conversation
ty-everett
changed the title
This was referenced Aug 15, 2026
ty-everett
marked this pull request as ready for review
August 15, 2026 01:52
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
August 15, 2026 01:52
…array # Conflicts: # docs/reference/package-api-migrations.md # docs/reference/stack-facts.md # governance/repository-health/baselines.json
|
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
number[]andUint8Arrayfast paths while supporting Buffer, cross-realm typed arrays, and historical contiguous numeric-key objects at schema-owned byte fieldsnormalizeWalletJsonTxhelper's historical top-level-only contractMessageEvent.origin, schemeless domains and ports normalize correctly, originless native events work, mismatches reject and clean up, and auto-detection is boundedReview follow-up
The two reported blockers are fixed:
{"eventName":"applicationEvent","data":{"0":1,"1":2}}now serializes and decodes unchanged. Real typed arrays still serialize as portable arrays. Historical numeric-key recovery occurs only at explicitly typed protocol fields.new WalletClient('react-native', 'myapp.com')integrations no longer pass the originator into the RN event filter. Explicit RN filters accept normalized full origins and originless native dispatch; a matching-origin mismatch rejects instead of hanging. Auto-detection has bounded 1-second fast probes and retains the 200 ms XDM fallback.The adjacent review items are also addressed:
{tx:{}}and other empty/byte-like application objects remain unchanged, the exported top-levelnormalizeWalletJsonTxbehavior is restored, stale mutation markers select every current target, and the governed marker is unique.Release scope
Patch/minor releases are prepared for SDK 2.4.1 and the affected dependent packages already versioned in this PR. No package or image has been published by this PR.
Validation
sdk-brc100-jsoncritical mutation target: 100% (19 killed / 0 survived / 0 no-coverage; 90% minimum)git diff --checkExact head:
48cbbccadaa682c2af9e39c2108e5f229f12bd0dHosted gates correctly blocked earlier revisions on five new Sonar maintainability findings and narrow portable bundle-size misses. The findings were fixed without changing compatibility behavior, and the existing browser/mobile ratchets were recalibrated to the exact reviewed artifacts with tight ceilings. The current
mainR1-K1 hardware-wallet merge was reconciled, its generated package ledgers were regenerated, and repository health remains clean. Hosted exact-head CI, CodeQL, Sonar, conformance, aggregate patch coverage, and the required merge gate are rerunning and must be terminal-successful before merge.