fix: E2E and staging stands seed their stores explicitly (post-P0-2)#194
Merged
Conversation
Both push-only lanes went red on the audit merge for the same reason: they still relied on the API provisioning and seeding its store on boot, which audit P0-2 removed. E2E hit 503/400/timeouts against an unprovisioned ClickHouse; the staging smoke got 404 for ORD-20260404-1001 from an empty embedded store. Both lanes were green on the previous main commit. - docker-compose.e2e.yml: one-shot serving-init service runs 'python -m src.serving.provision --schema --seed' against the in-stack ClickHouse before the API starts — the same job docker-compose.prod.yml already runs; the API now depends on its successful completion. The stale workflow comment claiming the API seeds on boot is corrected. - k8s/staging/values-staging.yaml: AGENTFLOW_SEED_ON_BOOT=true — the explicit demo-seed opt-in P0-2 left for exactly this ephemeral embedded profile. Verified live locally: fresh store + seed-on-boot boots, the smoke probes pass (entity ORD-20260404-1001 -> 200, 'Show me top 3 products' -> rows). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit merge (#189) turned the two push-only lanes red: E2E Tests and Staging Deploy still relied on the API provisioning and seeding its serving store on boot, which audit P0-2 deliberately removed. Both lanes were green on the previous main commit.
docker-compose.e2e.ymlgains the same one-shotserving-initservicedocker-compose.prod.ymlalready runs —python -m src.serving.provision --schema --seedagainst the in-stack ClickHouse, with the API depending on its successful completion. The stale workflow comment claiming the API seeds ClickHouse on boot is corrected.ORD-20260404-1001from an empty embedded store):AGENTFLOW_SEED_ON_BOOT=trueinvalues-staging.yaml— the explicit demo-seed opt-in P0-2 left for exactly this ephemeral embedded profile.Verified: compose parses with the new dependency chain;
helm templaterenders the env into the deployment; a live local boot with a fresh store + seed-on-boot passes the exact staging smoke probes (entity 200, NL query returns rows). The E2E/Staging lanes themselves only run on push to main and will re-verify on merge.🤖 Generated with Claude Code