fix(electron-ozone): ipcz leak on rohtmlwidget cycle OS-21158#139
Open
gostoshbs wants to merge 1 commit into
Open
fix(electron-ozone): ipcz leak on rohtmlwidget cycle OS-21158#139gostoshbs wants to merge 1 commit into
gostoshbs wants to merge 1 commit into
Conversation
Continuously creating and destroying Electron BrowserWindows in a loop causes the Electron main process's memory consumption to grow monotonically. Part of this is caused by ipcz leaving traps installed that persist and accumulate across BrowserWindow create/destroy cycles. These two patches address this by adding a removal API to ipcz and calling it from MojoTrap. Future upstream merges may address this leak differently. This change should be re-evaluated when Electron/Chromium is upgraded.
gostoshbs
assigned
caneraltinbasak and
t-bashir-bs and unassigned
caneraltinbasak and
t-bashir-bs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuously creating and destroying Electron BrowserWindows in a loop causes the Electron main process's memory consumption to grow monotonically. Part of this is caused by ipcz leaving traps installed that persist and accumulate across BrowserWindow create/destroy cycles. These two patches address this by adding a removal API to ipcz and calling it from MojoTrap.
Future upstream merges may address this leak differently. This change should be re-evaluated when Electron/Chromium is upgraded.